Standardize command related names #873
Conversation
st0012
force-pushed
the
rename-command-constants
branch
from
d66af64 to
5cb1821
Compare
|
I think we can maybe postpone the raise of deprecation warning. Otherwise, gems need to start requiring IRB release with this PR + start referencing to the new constants to avoid the warning. But at the same time, it won't bring immediate benefit to them, nor us, other than having clearer names in their codebase. Update: I decided not to raise deprecation warning on old constants. |
st0012
force-pushed
the
rename-command-constants
branch
from
7856c3d to
30ce967
Compare
|
It looks like some repository is requiring How about adding a file |
1. Rename lib/irb/extend-command.rb to lib/irb/command.rb 2. Rename lib/irb/cmd/*.rb to lib/irb/command/*.rb 3. Rename test/irb/test_cmd.rb to test/irb/test_command.rb 4. Rename ExtendCommand to Command
st0012
force-pushed
the
rename-command-constants
branch
from
30ce967 to
0d514c7
Compare
|
@tompng That's a good point 👍 |
(ruby/irb#873) * Replace ExtendCommand with Command and standardize command related names 1. Rename lib/irb/extend-command.rb to lib/irb/command.rb 2. Rename lib/irb/cmd/*.rb to lib/irb/command/*.rb 3. Rename test/irb/test_cmd.rb to test/irb/test_command.rb 4. Rename ExtendCommand to Command * Alias ExtendCommand to Command and deprecate it * Rename Command::Nop to Command::Base * Not deprecate old constants just yet * Add lib/irb/cmd/nop.rb back ruby/irb@462c1284af
Before we expose command extension APIs, I think it'd be beneficial to first standardize (or even modernize) the names we use for command related concepts. This includes namespace, base class, and folder names:
lib/irb/extend-command.rbtolib/irb/command.rblib/irb/cmd/*.rbtolib/irb/command/*.rbtest/irb/test_cmd.rbtotest/irb/test_command.rbExtendCommandtoCommandand alias it toCommandNoptoBaseand alias it toBase